Reworking Garden Models #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #441 +/- ##
============================================
- Coverage 92.39% 15.29% -77.11%
============================================
Files 28 28
Lines 3644 3811 +167
============================================
- Hits 3367 583 -2784
- Misses 277 3228 +2951 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major overhaul on how Gardens are tracked within Beer Garden.
Source and Target Gardens are now tracked on the Requests objects. Requests that are forwarded to children have the Source/Target Gardens removed. And when the update is sent back, the Target Garden is updated. So children always thing it originated within themselves.
Updating Gardens to track child Gardens. So it is easy to filter on the scope of control for each Garden. And giving insights into all downstream gardens.